[WIP] feat: harden post type usage and establish relationships between listings and posts/pages #43

dkoo · 2021-02-25T23:34:18Z

All Submissions:

Have you followed the Newspack Contributing guideline?
Does your code follow the WordPress' coding standards and VIP Go coding standards?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

This one is kind of big! Does a few things to lay the groundwork for establishing cross-data-type relationships:

Restricts the use of Business Listing patterns to the Place listing post type. This establishes Places as the de facto business data type, and Marketplace listings as more one-off classifieds which can be "owned" by one or more Places.
Creates shadow taxonomies for each listing post type. These taxonomies are automatically created, updated, or deleted when posts of the corresponding listing types are created, renamed, or unpublished, respectively.
Shadow taxonomies can be assigned to various post types. This lets us create associations between posts of different types—for example, Places can be assigned to Marketplace listings and Events. Listings can also be associated with other listings of the same type, which should let us show "related listings" more easily. This closes Harden post type usage #33.
Each shadow taxonomy can be assigned to specific listings of other types, and all can be assigned to pages and posts. Closes Direct associations with Posts and Pages #34.
When viewing a post, page, or listing that's been assigned listing shadow terms, we can automatically show a blurb and link for those associated listings. I've implemented a test version of this using the existing .author-bio styles from the Newspack theme, but this might need more design consideration (cc @thomasguillot).
Adds a couple of test block patterns for Marketplace listings (in the form of real estate listings). These are definitely placeholder patterns that I created mainly for testing purposes, so we'll want to revisit in another PR (cc @thomasguillot).
Adds a custom "Price" block that I figured would be useful for Marketplace listings (e.g. classifieds and real estate listings). This block editor is a fairly simple number input that also lets you select from a list of WooCommerce currencies (if available—defaults to the site's default currency, and falls back to USD if WooCommerce is not available) and then formats the number shown on the front-end with the corresponding currency symbol and internationalization based on the editor's browser settings—so if you choose Pound Sterling and you as an admin have a browser set to en-GB, it should show the number 10000 as £10,000.00. If you choose Euro and your browser is set to fr-FR, it should show 10 000,00 EUR. I based the formatting on the admin's browser settings because I figured that the price should be shown in the format familiar to the person creating the listing and choosing the currency. This block is also synced to a single meta field for listing CPTs, which automatically inherits the value from first instance of a Price block. This should be useful for future search and filtering features.

How to test the changes in this Pull Request:

Testing shadow taxonomies

After checking out this branch, edit a post or page—you should now see sidebar panels for each listing post type alongside categories and tags. Also confirm that terms are automatically created for pre-existing published listings (so editors who are already running listings won't need to go back and update or recreate those to get the new terms).

Edit listings of each type and confirm that you see sidebar panels for the listing post types designated as being assignable in class-newspack-listings-taxonomies.php. For example, you should be able to assign Events to other Events and Generic listings, Generic listings only to other Generic listings, Marketplace listings to Generic listings and other Marketplace listings, and Places to all listing types.
Assign some listings to posts, pages, and other listings and view the front-end.
You should see blurbs for each assigned listing at the bottom of the content (see below):

Note: I'm not sure the language ("Listed by", "Related listings") is quite right, but I'm also not sure what these headings should say. It seems particularly weird to show "Listed by" when some of the blurbs are of the same type (e.g., showing an Event blurb on another Event), but I'm also not sure what we should show in the case of related listings of the same type. The blurbs also visually clash with author bios and sponsor blurbs, if those are enabled. Open to suggestions.

For example, on a post or page:

On another listing:

Testing shadow taxonomy updating/deleting

Publish a new listing of any type.
Edit a post, page, or another listing that is able to receive that listing type as a shadow term.
Confirm that the new listing is searchable/selectable as a term in the editor sidebar.
Revert the listing to a draft.
Refresh the editor for the post/page/other listing and confirm that the listing term is no longer selectable or searchable.
Publish a new post of any type other than a listing and confirm that no new term is created under any of the listing shadow taxonomies.

Testing Price block

Create or edit a Marketplace listing.
Confirm that a new block called "Price" is now insertable through the Block Inserter. Conversely, confirm that the Price block is not available in any other post type.

Test the block functionality:

Enter numbers in the input field. Confirm that you can only enter numbers greater than or equal to 0.
Confirm that the Currency field defaults to the currency set for your site in WooCommerce settings (which is set during Newspack onboarding). If you want to go above and beyond, you can install Listings on a fresh site without WooCommerce and confirm that a.) the Currency field is hidden, and b.) formatted prices are only shown in US dollars.
Confirm that when unfocusing the input field, the number is automatically formatted with the selected currency and decimals (if "Show decimals" is off, then the number is rounded to the nearest integer, if on, then it's shown to the nearest hundredth). Confirm that the same is true on the front-end.
Choose various currencies and test the symbols and formatting in both the editor and front-end.

Change your browser language to something that will result in different number formatting than your usual language. For example, my Firefox is usually set to en-US, so I set it to fr-FR and restarted the browser app.
Edit the Marketplace listing with your Price block and confirm that the number shown is formatted according to your browser's language setting. For example, before setting my Firefox to fr-FR, the number 500000 in EUR is shown as €500,000.00. After changing to French, it's shown as 500 000,00 €.
Update the post and view on the front-end, and confirm the same. Verify that the format shown on the front-end matches the formatting last saved, not the reader's browser language.

Other information:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes, as applicable?
Have you successfully ran tests with your changes locally?

Also create a proof-of-concept Marketplace listing pattern to test block implementation.

adekbadek

The core functionality, as well as the new block, work well. There are some issues though - apart from the ones in separate comment:

The list of the assignable listings should not contain the edited listing.
In the taxonomy panel in the sidebar, after clicking "Add new ", the text above the input says: "New Category Name". I'd expect it to say "New ". After filling out this new listing name, confirming, and publishing, the listing is not created. I think the "Add new…" should rather link to editor creating a new listing.

includes/class-newspack-listings-taxonomies.php

src/blocks/price/edit.js

src/blocks/price/view.php

src/blocks/price/edit.js

includes/class-newspack-listings-block-patterns.php

includes/class-newspack-listings-taxonomies.php

adekbadek · 2021-04-05T14:04:52Z

includes/class-newspack-listings-taxonomies.php

+	}
+
+	/**
+	 * When a Place changes status, add/update the shadow term if the status is `publish`, otherwise delete it.


Why is only one of the four listing types handled here? After reverting a generic listing to draft, it was still available in the taxonomy sidebar on a post.

This was an oversight (since I started off with just one post type for testing). Should be fixed in a6f0195.

Not sure if that worked, I've found this issue:

Create a Place

Assign it to a Marketplace

Rename the place

Edit the Marketplace - there is now an additional Place taxonomy item - both old and new name are listed are assignable taxonomy options

Also, the comment still mentions "Place" ;)

adekbadek

(commented in existing thread)

adekbadek · 2021-04-23T10:42:51Z

Should we consider adding a test suite in a separate PR after this lands? Since we're not releasing Phase 2 features until all are complete, we'd have a chance to catch any errors with this PR again once the tests are implemented.

Since this is not merged to master, the tests can be added later, but I'd be wary of merging Phase 2 as a single huge PR. This would introduce a lot of potential of errors.

dkoo · 2021-04-23T16:00:19Z

I'd be wary of merging Phase 2 as a single huge PR. This would introduce a lot of potential of errors.

Definitely something I've thought about, but the features outlined for a Phase 2 release don't make much sense to roll out individually. The approach we've taken in reviewing and merging smaller PRs against a clone of master (while minimizing updates to master in the meantime) should hopefully minimize the errors when we finally merge that branch.

includes/class-newspack-listings-taxonomies.php

dkoo · 2021-04-29T18:01:25Z

@thomasguillot Since your redesigned UI won't affect the back-end portion of this PR, and this isn't getting released until all phase 2 PRs are approved, I'm going to merge this and handle the new UI in a separate PR.

matticbot · 2021-06-21T21:27:56Z

🎉 This PR is included in version 2.0.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

* chore: replace AutocompleteTokenfield with Newspack Components version (#40) * feat: use post categories and tags for all listing post types (#39) * feat: use post categories and tags for all listing post types * fix: undo patterns post type changes (for another PR) * chore: remove unneeded admin page highlighting filter BREAKING CHANGE: This feature will deprecate existing custom taxonomies, so any existing terms for those taxonomies will be lost. To fix, we can convert terms from the deprecated taxonomies to standard post categories/tags via a migration script. Fixes #32. * feat: better integration with Newspack Theme features * feat: add settings for individual listing type URL slugs Closes #41. * fix: wp_insert_post filter name and theme_mod filter * fix: newspack_blocks support slug * feat: add revisions support for listings * chore: update outdated docblock * refactor: use material icons with Newspack color * fix: warning about default meta value * fix: util for checking post type on new posts * chore: update label of "hide author" setting * feat: flush permalinks automatically if updating slug option * feat: update cpt icon and block icons See #49 * fix: remove material packages * fix: failing npm ci command * [WIP] feat: harden post type usage and establish relationships between listings and posts/pages (#43) * feat: make Business patterns applicable only to places * feat: create shadow taxonomy for places * feat: add ability to associate Places with regular posts and pages * fix: remove default map markers from patterns * feat: new Price block for Marketplace listings Also create a proof-of-concept Marketplace listing pattern to test block implementation. * feat: add meta field with data synced from Price block * feat: second test pattern * fix: incorrect conditional for updating shadow terms (whoops) * feat: abstract shadow tax functions to make it easier to add more * refactor: simplify setting formattedPrice attribute via useEffect * chore: fix PHP warning about passing variables * feat: shadow taxonomies for all CPTs; test automated related listings * fix: avoid showing post on itself * fix: incorrect var assignment * fix: decode HTML entities before rendering currency options * chore: fix function/class docs * fix: formatting an empty string results in NaN * fix: wrong post type being returned by util * fix: handle all listing post types for shadow taxonomies * fix: don't show the shadow taxonomy for the post being edited * feat: add new post button for shadow taxonomies * chore: instantiate var as empty array, just in case * fix: updating of terms, and delete orphan terms * fix: replace Material icon with WordPress icon * feat: custom UI for parent/child listings instead of WP taxonomy UI * chore: update function comment * chore: remove commented-out code * fix: posts/pages child search fields; only show child UI if published * fix: logical errors in validation method 🤦 * chore: update function name and comments for clarity * refactor: use AutocompleteWithSuggestions from newspack-components (#56) * feat: CSV importer script (#51) * feat: init CSV importer via CLI command * refactor: move importer files to subdir * feat: take field mappings from config file instead of hard-coding them * feat: add (currently unused) image_ids meta field for future use * feat: process meta fields and content into block patterns * fix: mismatch between data types in term handling * feat: support multiple post types for importing * docs: add README and sample config * fix: do not apply content filters to legacy content upon importing * chore: description * fix: check if default post type constant is a listing * feat: update block template; handle social media links * feat: importer edits for GDG * feat: add a new global setting and post option to hide date (#57) * fix: use value property of selection from AutocompleteWithSuggestions (#61) * fix: use value property of selection from AutocompleteWithSuggestions * fix: cast listing ID value as an integer * fix: cast listing IDs as strings to avoid breaking existing listings * feat: convert legacy custom terms to regular post terms (#67) * test: init test suite (#60) * test: init test suite * chore: fix function comment * chore: remove redundant lint-php NPM script * feat: if no view.php, register blocks with default attributes * fix: activation PHP warning (#70) * feat: support Newspack Sponsors for listings (#65) * feat: support Newspack Sponsors * refactor: response object with author and sponsors * fix: sponsors for queried listings * feat: update price block to use placeholder and large font size (#71) * fix: guard against nonexistent meta object (#66) * feat: child and related listings UI (#58) * feat: initial exploration of UI in a modal * fix: filter out parent post from child listings response * feat: child and related listings UI * chore: clear messages when closing modals * chore: hide shadow terms from menu * chore: handle errors from fetching suggestions * chore: more context-sensitive labels for child/parent UI * chore: update empty message * refactor: make parent/child UI components more self-contained, reusable * chore: update newspack-components * fix: parent/child listings UI bugs * chore: rename "Child Listings" to "Related Content" * fix: default listings to one-column-wide.php post template (#77) * chore: gate legacy taxonomy term deletion behind an environment constant * fix: memory leaks from legacy term utilities (#81) * feat: gate custom tax migration behind env flag to avoid expensive ops * feat: move legacy taxonomy migrator script to a CLI command * chore: rename CLI command and use ::log instead of ::line * refactor: move missing/orphan shadow term handling to WP CLI Co-authored-by: Thomas Guillot <info@thomasguillot.com> Co-authored-by: Thomas Guillot <thomasguillot@users.noreply.github.com>

# [2.0.0-alpha.3](v2.0.0-alpha.2...v2.0.0-alpha.3) (2021-07-06) * v2 release (#85) ([748810d](748810d)), closes [#85](#85) [#40](#40) [#39](#39) [#32](#32) [#41](#41) [#49](#49) [#43](#43) [#56](#56) [#51](#51) [#57](#57) [#61](#61) [#67](#67) [#60](#60) [#70](#70) [#65](#65) [#71](#71) [#66](#66) [#58](#58) [#77](#77) [#81](#81) ### Bug Fixes * errors and bugs related to WP 5.8 ([#83](#83)) ([90da6c5](90da6c5)) ### BREAKING CHANGES * This feature will deprecate existing custom taxonomies, so any existing terms for those taxonomies will be lost. To fix, we can convert terms from the deprecated taxonomies to standard post categories/tags via a migration script.

# [2.0.0](v1.2.2...v2.0.0) (2021-07-06) * v2 release (#85) ([748810d](748810d)), closes [#85](#85) [#40](#40) [#39](#39) [#32](#32) [#41](#41) [#49](#49) [#43](#43) [#56](#56) [#51](#51) [#57](#57) [#61](#61) [#67](#67) [#60](#60) [#70](#70) [#65](#65) [#71](#71) [#66](#66) [#58](#58) [#77](#77) [#81](#81) ### Bug Fixes * errors and bugs related to WP 5.8 ([#83](#83)) ([90da6c5](90da6c5)) ### BREAKING CHANGES * This feature will deprecate existing custom taxonomies, so any existing terms for those taxonomies will be lost. To fix, we can convert terms from the deprecated taxonomies to standard post categories/tags via a migration script.

* chore: replace AutocompleteTokenfield with Newspack Components version (#40) * feat: use post categories and tags for all listing post types (#39) * feat: use post categories and tags for all listing post types * fix: undo patterns post type changes (for another PR) * chore: remove unneeded admin page highlighting filter BREAKING CHANGE: This feature will deprecate existing custom taxonomies, so any existing terms for those taxonomies will be lost. To fix, we can convert terms from the deprecated taxonomies to standard post categories/tags via a migration script. Fixes #32. * feat: better integration with Newspack Theme features * feat: add settings for individual listing type URL slugs Closes #41. * fix: wp_insert_post filter name and theme_mod filter * fix: newspack_blocks support slug * feat: add revisions support for listings * chore: update outdated docblock * refactor: use material icons with Newspack color * fix: warning about default meta value * fix: util for checking post type on new posts * chore: update label of "hide author" setting * feat: flush permalinks automatically if updating slug option * feat: update cpt icon and block icons See #49 * fix: remove material packages * fix: failing npm ci command * [WIP] feat: harden post type usage and establish relationships between listings and posts/pages (#43) * feat: make Business patterns applicable only to places * feat: create shadow taxonomy for places * feat: add ability to associate Places with regular posts and pages * fix: remove default map markers from patterns * feat: new Price block for Marketplace listings Also create a proof-of-concept Marketplace listing pattern to test block implementation. * feat: add meta field with data synced from Price block * feat: second test pattern * fix: incorrect conditional for updating shadow terms (whoops) * feat: abstract shadow tax functions to make it easier to add more * refactor: simplify setting formattedPrice attribute via useEffect * chore: fix PHP warning about passing variables * feat: shadow taxonomies for all CPTs; test automated related listings * fix: avoid showing post on itself * fix: incorrect var assignment * fix: decode HTML entities before rendering currency options * chore: fix function/class docs * fix: formatting an empty string results in NaN * fix: wrong post type being returned by util * fix: handle all listing post types for shadow taxonomies * fix: don't show the shadow taxonomy for the post being edited * feat: add new post button for shadow taxonomies * chore: instantiate var as empty array, just in case * fix: updating of terms, and delete orphan terms * fix: replace Material icon with WordPress icon * feat: custom UI for parent/child listings instead of WP taxonomy UI * chore: update function comment * chore: remove commented-out code * fix: posts/pages child search fields; only show child UI if published * fix: logical errors in validation method 🤦 * chore: update function name and comments for clarity * refactor: use AutocompleteWithSuggestions from newspack-components (#56) * feat: CSV importer script (#51) * feat: init CSV importer via CLI command * refactor: move importer files to subdir * feat: take field mappings from config file instead of hard-coding them * feat: add (currently unused) image_ids meta field for future use * feat: process meta fields and content into block patterns * fix: mismatch between data types in term handling * feat: support multiple post types for importing * docs: add README and sample config * fix: do not apply content filters to legacy content upon importing * chore: description * fix: check if default post type constant is a listing * feat: update block template; handle social media links * feat: importer edits for GDG * feat: add a new global setting and post option to hide date (#57) * fix: use value property of selection from AutocompleteWithSuggestions (#61) * fix: use value property of selection from AutocompleteWithSuggestions * fix: cast listing ID value as an integer * fix: cast listing IDs as strings to avoid breaking existing listings * feat: convert legacy custom terms to regular post terms (#67) * test: init test suite (#60) * test: init test suite * chore: fix function comment * chore: remove redundant lint-php NPM script * feat: if no view.php, register blocks with default attributes * fix: activation PHP warning (#70) * feat: support Newspack Sponsors for listings (#65) * feat: support Newspack Sponsors * refactor: response object with author and sponsors * fix: sponsors for queried listings * feat: update price block to use placeholder and large font size (#71) * fix: guard against nonexistent meta object (#66) * feat: child and related listings UI (#58) * feat: initial exploration of UI in a modal * fix: filter out parent post from child listings response * feat: child and related listings UI * chore: clear messages when closing modals * chore: hide shadow terms from menu * chore: handle errors from fetching suggestions * chore: more context-sensitive labels for child/parent UI * chore: update empty message * refactor: make parent/child UI components more self-contained, reusable * chore: update newspack-components * fix: parent/child listings UI bugs * chore: rename "Child Listings" to "Related Content" * fix: default listings to one-column-wide.php post template (#77) * chore: gate legacy taxonomy term deletion behind an environment constant * fix: memory leaks from legacy term utilities (#81) * feat: gate custom tax migration behind env flag to avoid expensive ops * feat: move legacy taxonomy migrator script to a CLI command * chore: rename CLI command and use ::log instead of ::line * refactor: move missing/orphan shadow term handling to WP CLI * feat: block patterns for real estate and classifieds * fix: import pattern styles into editor SCSS * fix: restore patterns after merge * refactor: remove placeholder image URLs from patterns Co-authored-by: Thomas Guillot <info@thomasguillot.com> Co-authored-by: Thomas Guillot <thomasguillot@users.noreply.github.com>

# [3.0.0-alpha.1](v2.0.1...v3.0.0-alpha.1) (2021-07-19) ### Bug Fixes * avoid meta sync update error ([#95](#95)) ([cab16aa](cab16aa)) * do not register post-specific sidebars in widgets page ([#93](#93)) ([7716775](7716775)) ### Features * bump max number of items per list from 20 to 50 ([#97](#97)) ([009deab](009deab)) * more block patterns (real estate, classified ads) ([#84](#84)) ([e76acc3](e76acc3)), closes [#40](#40) [#39](#39) [#32](#32) [#41](#41) [#49](#49) [#43](#43) [#56](#56) [#51](#51) [#57](#57) [#61](#61) [#67](#67) [#60](#60) [#70](#70) [#65](#65) [#71](#71) [#66](#66) [#58](#58) [#77](#77) [#81](#81) ### BREAKING CHANGES * This feature will deprecate existing custom taxonomies, so any existing terms for those taxonomies will be lost. To fix, we can convert terms from the deprecated taxonomies to standard post categories/tags via a migration script.

# [3.0.0-alpha.1](v2.0.1...v3.0.0-alpha.1) (2021-07-19) ### Bug Fixes * avoid meta sync update error ([#95](#95)) ([cab16aa](cab16aa)) * do not register post-specific sidebars in widgets page ([#93](#93)) ([7716775](7716775)) ### Features * bump max number of items per list from 20 to 50 ([#97](#97)) ([009deab](009deab)) * more block patterns (real estate, classified ads) ([#84](#84)) ([a51f5af](a51f5af)) * more block patterns (real estate, classified ads) ([#84](#84)) ([e76acc3](e76acc3)), closes [#40](#40) [#39](#39) [#32](#32) [#41](#41) [#49](#49) [#43](#43) [#56](#56) [#51](#51) [#57](#57) [#61](#61) [#67](#67) [#60](#60) [#70](#70) [#65](#65) [#71](#71) [#66](#66) [#58](#58) [#77](#77) [#81](#81) ### BREAKING CHANGES * This feature will deprecate existing custom taxonomies, so any existing terms for those taxonomies will be lost. To fix, we can convert terms from the deprecated taxonomies to standard post categories/tags via a migration script.

# 1.0.0-alpha.1 (2021-07-19) ### Bug Fixes * avoid meta sync update error ([#95](#95)) ([cab16aa](cab16aa)) * do not register post-specific sidebars in widgets page ([#93](#93)) ([7716775](7716775)) * editor errors with reusable blocks ([#89](#89)) ([fdc46d3](fdc46d3)) * errors and bugs related to WP 5.8 ([#83](#83)) ([90da6c5](90da6c5)) * force alpha rebuild ([acc2075](acc2075)) * minor bug fixes ([#21](#21)) ([5f90bc7](5f90bc7)) * missing condition for block appender in list container ([#74](#74)) ([2c49896](2c49896)) * syncing attributes from curated list block to inner blocks ([#64](#64)) ([cdbc0bb](cdbc0bb)) * use synced attributes for ListContainer directly ([#73](#73)) ([f8641a7](f8641a7)) ### Features * add block patterns ([#23](#23)) ([a273a40](a273a40)) * bump max number of items per list from 20 to 50 ([#97](#97)) ([009deab](009deab)) * initial post type and block setup ([#1](#1)) ([47dc0c1](47dc0c1)) * listing taxonomies and query mode ([#6](#6)) ([528e1e5](528e1e5)) * more block patterns (real estate, classified ads) ([#84](#84)) ([a51f5af](a51f5af)) * new Curated List block, block pattern, and map functionality ([#3](#3)) ([9be6e7e](9be6e7e)) * remove borders and padding in editor to match front-end styles ([#14](#14)) ([6c47a17](6c47a17)) * v2 release (#85) ([748810d](748810d)), closes [#85](#85) [#40](#40) [#39](#39) [#32](#32) [#41](#41) [#49](#49) [#43](#43) [#56](#56) [#51](#51) [#57](#57) [#61](#61) [#67](#67) [#60](#60) [#70](#70) [#65](#65) [#71](#71) [#66](#66) [#58](#58) [#77](#77) [#81](#81) ### BREAKING CHANGES * This feature will deprecate existing custom taxonomies, so any existing terms for those taxonomies will be lost. To fix, we can convert terms from the deprecated taxonomies to standard post categories/tags via a migration script.

dkoo added 2 commits February 25, 2021 14:29

feat: make Business patterns applicable only to places

d44cace

feat: create shadow taxonomy for places

0a7a1cb

dkoo self-assigned this Feb 25, 2021

dkoo added this to the Phase 2 milestone Feb 25, 2021

dkoo added the enhancement New feature or request label Feb 25, 2021

dkoo linked an issue Feb 25, 2021 that may be closed by this pull request

Harden post type usage #33

Closed

dkoo added 12 commits March 19, 2021 10:14

Merge branch 'epic/phase-2' into feat/data-type-usage

c1f2c5e

feat: add ability to associate Places with regular posts and pages

c05c6c6

Merge branch 'epic/phase-2' into feat/data-type-usage

084dad5

fix: remove default map markers from patterns

87b3708

feat: new Price block for Marketplace listings

4d4d4b8

Also create a proof-of-concept Marketplace listing pattern to test block implementation.

feat: add meta field with data synced from Price block

082cf5a

feat: second test pattern

1177275

fix: incorrect conditional for updating shadow terms (whoops)

54e3fde

feat: abstract shadow tax functions to make it easier to add more

5256dd2

refactor: simplify setting formattedPrice attribute via useEffect

023e37e

chore: fix PHP warning about passing variables

9c3f687

feat: shadow taxonomies for all CPTs; test automated related listings

5c6bf0c

dkoo changed the title ~~feat: harden post type usage and establish parent/child relationship b/w Places and Marketplace/Events~~ feat: harden post type usage and establish relationships between listings and posts/pages Mar 31, 2021

dkoo linked an issue Mar 31, 2021 that may be closed by this pull request

Direct associations with Posts and Pages #34

Closed

dkoo added the [Status] Needs Review label Apr 1, 2021

dkoo requested review from jeffersonrabb and adekbadek April 1, 2021 00:33

dkoo marked this pull request as ready for review April 1, 2021 01:11

adekbadek requested changes Apr 5, 2021

View reviewed changes

adekbadek added [Status] Needs changes or feedback and removed [Status] Needs Review labels Apr 5, 2021

dkoo added 3 commits April 5, 2021 10:02

fix: avoid showing post on itself

caa1938

fix: incorrect var assignment

f2d554c

fix: decode HTML entities before rendering currency options

621c497

fix: posts/pages child search fields; only show child UI if published

527fe4d

dkoo requested a review from adekbadek April 22, 2021 23:12

adekbadek requested changes Apr 23, 2021

View reviewed changes

fix: logical errors in validation method 🤦

4b43a7c

dkoo requested a review from adekbadek April 23, 2021 18:30

dkoo added [Status] Needs Review and removed WIP [Status] Needs changes or feedback labels Apr 23, 2021

adekbadek reviewed Apr 26, 2021

View reviewed changes

includes/class-newspack-listings-taxonomies.php Outdated Show resolved Hide resolved

dkoo requested review from adekbadek and removed request for jeffersonrabb April 26, 2021 19:53

chore: update function name and comments for clarity

a136170

adekbadek approved these changes Apr 29, 2021

View reviewed changes

github-actions bot added [Status] Approved and removed [Status] Needs Review labels Apr 29, 2021

dkoo merged commit c04cb80 into epic/phase-2 Apr 29, 2021

dkoo deleted the feat/data-type-usage branch April 29, 2021 18:01

dkoo mentioned this pull request May 6, 2021

feat: add an AutocompleteWithSuggestions component for reusability Automattic/newspack-plugin#952

Merged

6 tasks

matticbot added the released on @alpha label Jun 21, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] feat: harden post type usage and establish relationships between listings and posts/pages #43

[WIP] feat: harden post type usage and establish relationships between listings and posts/pages #43

dkoo commented Feb 25, 2021 •

edited

Loading

adekbadek left a comment

adekbadek Apr 5, 2021

dkoo Apr 5, 2021

adekbadek Apr 6, 2021

adekbadek Apr 6, 2021

adekbadek left a comment

adekbadek commented Apr 23, 2021

dkoo commented Apr 23, 2021

dkoo commented Apr 29, 2021

matticbot commented Jun 21, 2021

[WIP] feat: harden post type usage and establish relationships between listings and posts/pages #43

[WIP] feat: harden post type usage and establish relationships between listings and posts/pages #43

Conversation

dkoo commented Feb 25, 2021 • edited Loading

All Submissions:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Testing shadow taxonomies

Testing shadow taxonomy updating/deleting

Testing Price block

Other information:

adekbadek left a comment

Choose a reason for hiding this comment

adekbadek Apr 5, 2021

Choose a reason for hiding this comment

dkoo Apr 5, 2021

Choose a reason for hiding this comment

adekbadek Apr 6, 2021

Choose a reason for hiding this comment

adekbadek Apr 6, 2021

Choose a reason for hiding this comment

adekbadek left a comment

Choose a reason for hiding this comment

adekbadek commented Apr 23, 2021

dkoo commented Apr 23, 2021

dkoo commented Apr 29, 2021

matticbot commented Jun 21, 2021

dkoo commented Feb 25, 2021 •

edited

Loading